Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: chrome/browser/extensions/extension_function.h

Issue 114033: Fix a crash in the extension system when sending response back (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_function.h
===================================================================
--- chrome/browser/extensions/extension_function.h (revision 16294)
+++ chrome/browser/extensions/extension_function.h (working copy)
@@ -28,6 +28,7 @@
class ExtensionFunction {
public:
ExtensionFunction() : request_id_(-1), has_callback_(false) {}
+ virtual ~ExtensionFunction() {}
// Specifies the name of the function.
virtual void SetName(const std::string& name) { }
@@ -79,7 +80,7 @@
// parsing JSON (and instead uses custom serialization of Value objects).
class AsyncExtensionFunction : public ExtensionFunction {
public:
- AsyncExtensionFunction() : bad_message_(false) {}
+ AsyncExtensionFunction() : args_(NULL), bad_message_(false) {}
virtual ~AsyncExtensionFunction() {}
virtual void SetArgs(const std::string& args);
@@ -94,7 +95,7 @@
Profile* profile();
- // The arguments to the API. Only non-null if argument were specfied.
+ // The arguments to the API. Only non-null if argument were specified.
Value* args_;
// The result of the API. This should be populated by the derived class before
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698