Issue 113996: Move a few functions commonly called with char* to StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113996: Move a few functions commonly called with char* to StringPiece. (Closed)

Created:
11 years, 6 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Move a few functions commonly called with char* to StringPiece. In some cases this will avoid the implicit char* -> std::string conversion, object creation, and string copying. One of the biggest benefit is on Windows, where we can save some conversions in FilePath::AppendASCII.

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -9 lines)			Patch
M	base/file_path.h	View	2 chunks	+2 lines, -1 line	1 comment	Download
M	base/file_path.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/string_util.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/string_util.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

Would be nice to support StringPiece for Append() on Linux/Mac, which would avoid the conversions ...

11 years, 6 months ago (2009-05-29 10:19:18 UTC) #1

Mark Mentovai

11 years, 6 months ago (2009-05-29 13:04:55 UTC) #2

LGTM

http://codereview.chromium.org/113996/diff/1/3
File base/file_path.h (right):

http://codereview.chromium.org/113996/diff/1/3#newcode73
Line 73: #include "base/string_piece.h"  // For implicit conversions.
I don't think comments like this for #includes are terribly useful - the
comments about StringPiece implicit conversions belong in string_piece.h, not
here.

Expand Messages | Collapse Messages