Chromium Code Reviews

Unified Diff: base/file_path.h

Issue 113996: Move a few functions commonly called with char* to StringPiece. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | base/file_path.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_path.h
diff --git a/base/file_path.h b/base/file_path.h
index d4f35d1b614fa7c045d4a806817fab5c40f1e6b0..73de4a6032f409f2b95905ffcceee59c1f85b633 100644
--- a/base/file_path.h
+++ b/base/file_path.h
@@ -70,6 +70,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/hash_tables.h"
+#include "base/string_piece.h" // For implicit conversions.
Mark Mentovai 2009/05/29 13:04:55 I don't think comments like this for #includes are
// Windows-style drive letter support and pathname separator characters can be
// enabled and disabled independently, to aid testing. These #defines are
@@ -199,7 +200,7 @@ class FilePath {
// On Linux, although it can use any 8-bit encoding for paths, we assume that
// ASCII is a valid subset, regardless of the encoding, since many operating
// system paths will always be ASCII.
- FilePath AppendASCII(const std::string& component) const WARN_UNUSED_RESULT;
+ FilePath AppendASCII(const StringPiece& component) const WARN_UNUSED_RESULT;
// Returns true if this FilePath contains an absolute path. On Windows, an
// absolute path begins with either a drive letter specification followed by
« no previous file with comments | « no previous file | base/file_path.cc » ('j') | no next file with comments »

Powered by Google App Engine