Issue 113976: Fix broken Gears after gyp conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113976: Fix broken Gears after gyp conversion. (Closed)

Created:
11 years, 6 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Fix broken Gears after gyp conversion. The path to gears.dll has changed. BUG=12844 TEST=Install Chromium and make sure gears.dll is present.

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/installer/mini_installer/chrome.release	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/tools/build/win/FILES	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

bradn

Actually should gyp put it where is was before? I can sent you the incantation.

11 years, 6 months ago (2009-05-28 23:01:26 UTC) #2

kuchhal

I think the new path is really correct, plugins\gears was necessary when we had gears.dll ...

11 years, 6 months ago (2009-05-28 23:09:37 UTC) #3

kuchhal

I have added another file that buildbot scripts use for archive. Can you take another ...

11 years, 6 months ago (2009-05-28 23:18:32 UTC) #4

LGTM