Add gears.dll to Chrome installer. Also uninstall gears.msi if new installer ...

Add gears.dll to Chrome installer. Also uninstall gears.msi if new installer succeeds.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2320

[kuchhal, 2008-09-17 18:03:17]

Matt, the change is pretty minor.

Mark, before we push this new installer to users we will need to change Omaha
configs to stop sending gears.msi to users.

[Matt Perry, 2008-09-17 18:20:23]

http://codereview.chromium.org/2938/diff/1/3
File chrome/installer/mini_installer/chrome.release (right):

http://codereview.chromium.org/2938/diff/1/3#newcode36
Line 36: plugins\gears\gears.dll: %(VersionDir)s\
Could we instead change gears.vcproj to copy itself to OutputDir, rather than
OutputDir\plugins\gears?  Then we could change this rule to gears.dll: ...

http://codereview.chromium.org/2938/diff/1/2
File chrome/installer/setup/main.cc (right):

http://codereview.chromium.org/2938/diff/1/2#newcode259
Line 259: LOG(ERROR) << "Failed to uninstall Gears " << product;
Will this cause the update to fail?  I think we should try to uninstall
gears.msi, but ignore any failures and allow the chrome update to succeed
regardless.

[Matt Perry, 2008-09-17 18:37:43]

Good points, LGTM.