Linux: work around the fact that the download dialog has not been ported....

Generalize the code that checks for user actions in the render view to work on all platforms.

Also, on linux, assume the user denies every download which we would have prompted him with.

BUG=12709
TEST=windows is still carpet-bombing resilient and linux can download from the same page more than once.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17089

[Evan Stade, 2009-05-27 22:51:00]

I have never even seen a download prompt and don't know what it's used for.
Reading the code, it seems that the default value for the tab's download state
is ALLOW_ONE_DOWNLOAD, so I don't know why on windows we don't get a dialog for
the second download. Paul?

Anyway, for now, since we don't have a dialog, just allow all downloads. This
fixes the problem that you can't download more than one file from a site.

[Evan Stade, 2009-05-27 22:55:23]

nvm, hold off on reviewing.

[Evan Stade, 2009-05-28 00:07:29]

k, ready for review. I'm building on windows to test.

[Paul Godavari, 2009-05-28 00:32:13]

LGTM.

http://codereview.chromium.org/113925/diff/1/2
File chrome/browser/download/download_request_manager.cc (right):

http://codereview.chromium.org/113925/diff/1/2#newcode71
Line 71: else {
nit: need braces on the if clause, too.

[Evan Stade, 2009-05-28 00:58:37]

http://codereview.chromium.org/113925/diff/1/2
File chrome/browser/download/download_request_manager.cc (right):

http://codereview.chromium.org/113925/diff/1/2#newcode71
Line 71: else {
On 2009/05/28 00:32:13, Paul Godavari wrote:
> nit: need braces on the if clause, too.

sorry, this is the wrong patch set. Please review patch set 4. I'll fix the lint
error though.

[Paul Godavari, 2009-05-28 01:05:17]

LGTM.