Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3142)

Unified Diff: chrome/browser/download/download_request_manager.cc

Issue 113925: Linux: work around the fact that the download dialog has not been ported.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process.cc ('k') | chrome/browser/renderer_host/render_view_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_request_manager.cc
===================================================================
--- chrome/browser/download/download_request_manager.cc (revision 17020)
+++ chrome/browser/download/download_request_manager.cc (working copy)
@@ -66,10 +66,15 @@
if (is_showing_prompt())
return; // Already showing prompt.
- if (DownloadRequestManager::delegate_)
+ if (DownloadRequestManager::delegate_) {
NotifyCallbacks(DownloadRequestManager::delegate_->ShouldAllowDownload());
- else
+ } else {
dialog_delegate_ = DownloadRequestDialogDelegate::Create(tab, this);
+ // TODO(estade): the dialog delegate isn't yet implemented on linux. Just
+ // assume we shouldn't allow the download.
+ if (dialog_delegate_ == NULL)
+ NotifyCallbacks(false);
+ }
}
void DownloadRequestManager::TabDownloadState::Cancel() {
« no previous file with comments | « chrome/browser/browser_process.cc ('k') | chrome/browser/renderer_host/render_view_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698