Issue 113919: Adds gtk_util::ParentWindow to find the parent window of a GtkWidget....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113919: Adds gtk_util::ParentWindow to find the parent window of a GtkWidget.... (Closed)

Created:
11 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
tony, agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds gtk_util::ParentWindow to find the parent window of a GtkWidget. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17019

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	chrome/common/gtk_util.h	View		1 chunk	+4 lines, -0 lines	1 comment	Download
	M	chrome/common/gtk_util.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

Adam, as Evan is out today could you review this one. Thanks, -Scott

11 years, 7 months ago (2009-05-27 20:24:01 UTC) #2

agl

LGTM with nit. http://codereview.chromium.org/113919/diff/1/3 File chrome/common/gtk_util.h (right): http://codereview.chromium.org/113919/diff/1/3#newcode47 Line 47: // Returns the first ancestor ...

11 years, 7 months ago (2009-05-27 20:30:06 UTC) #3

Is this the same as widget->window?

Expand Messages | Collapse Messages