Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1398)

Unified Diff: presubmit_canned_checks.py

Issue 113883: Remove SPECIAL_KEYS and GclChange.Changelist() to simplify the code. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | presubmit_support.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 1b6d6465bdb254ff705426b5d210c996a084cbcf..faf290ae1371e120dbe061e94469e12db5f3302d 100755
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -8,7 +8,7 @@
def CheckChangeHasTestField(input_api, output_api):
"""Requires that the changelist have a TEST= field."""
- if input_api.change.Test:
+ if input_api.change.TEST:
return []
else:
return [output_api.PresubmitNotifyResult(
@@ -17,7 +17,7 @@ def CheckChangeHasTestField(input_api, output_api):
def CheckChangeHasBugField(input_api, output_api):
"""Requires that the changelist have a BUG= field."""
- if input_api.change.BugIDs:
+ if input_api.change.BUG:
return []
else:
return [output_api.PresubmitNotifyResult(
@@ -26,7 +26,7 @@ def CheckChangeHasBugField(input_api, output_api):
def CheckChangeHasTestedField(input_api, output_api):
"""Requires that the changelist have a TESTED= field."""
- if input_api.change.Tested:
+ if input_api.change.TESTED:
return []
else:
return [output_api.PresubmitError("Changelist must have a TESTED= field.")]
« no previous file with comments | « no previous file | presubmit_support.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698