Remove SPECIAL_KEYS and GclChange.Changelist() to simplify the code.

presubmit_canned_checks.py

 #!/usr/bin/env python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 def CheckChangeHasTestField(input_api, output_api):
   """Requires that the changelist have a TEST= field."""
-  if input_api.change.Test:
+  if input_api.change.TEST:
     return []
   else:
     return [output_api.PresubmitNotifyResult(
         "Changelist should have a TEST= field. TEST=none is allowed.")]
 
 
 def CheckChangeHasBugField(input_api, output_api):
   """Requires that the changelist have a BUG= field."""
-  if input_api.change.BugIDs:
+  if input_api.change.BUG:
     return []
   else:
     return [output_api.PresubmitNotifyResult(
         "Changelist should have a BUG= field. BUG=none is allowed.")]
 
 
 def CheckChangeHasTestedField(input_api, output_api):
   """Requires that the changelist have a TESTED= field."""
-  if input_api.change.Tested:
+  if input_api.change.TESTED:
     return []
   else:
     return [output_api.PresubmitError("Changelist must have a TESTED= field.")]
 
 
 def CheckChangeHasQaField(input_api, output_api):
   """Requires that the changelist have a QA= field."""
   if input_api.change.QA:
     return []
   else:
@@ skipping 98 matching lines @@
     except ImportError:
       outputs.Append(output_api.PresubmitError("Failed to load %s" % unit_test))
       raise
 
   results = unittest.TextTestRunner(verbosity=0).run(unittest.TestSuite(
       tests_suite))
   if not results.wasSuccessful():
     outputs.append(output_api.PresubmitError(
         "%d unit tests failed." % (results.failures + results.errors)))
   return outputs