Revert the password manager refactoring -- it failed reliability tests.

Revert the password manager refactoring -- it failed reliability tests.

(For reference, it was committed with the wrong message: "Patch to make
password patch build.")

This reverts commit r16708.

[stuartmorgan, 2009-05-26 22:54:03]

:(

Should we leave the various password_store files in the tree, and just pull out
the refactoring of existing files and the build bits?

http://codereview.chromium.org/113871/diff/1/21
File chrome/chrome.gyp (left):

http://codereview.chromium.org/113871/diff/1/21#oldcode1110
Line 1110: 'browser/password_manager/password_store_mac.cc',
There's a corresponding _unittest for this file that will also need to be
removed from chrome.gyp

[Evan Martin, 2009-05-26 22:55:59]

Really sorry! I reverted it TBR because it was blocking the dev build.

If you'd like to finish this patch, it would be very appreciated.   John (its
author) is a 20%er and doesn't have a Windows box.  I don't have time right now
to work on it.

Strangely, this commit passed the trybots so I didn't think it should affect
mac?

On 2009/05/26 22:54:03, stuartmorgan wrote:
> :(
> 
> Should we leave the various password_store files in the tree, and just pull
out
> the refactoring of existing files and the build bits?
> 
> http://codereview.chromium.org/113871/diff/1/21
> File chrome/chrome.gyp (left):
> 
> http://codereview.chromium.org/113871/diff/1/21#oldcode1110
> Line 1110: 'browser/password_manager/password_store_mac.cc',
> There's a corresponding _unittest for this file that will also need to be
> removed from chrome.gyp