Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: chrome/browser/password_manager/password_store_default.cc

Issue 113871: Revert the password manager refactoring -- it failed reliability tests. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_default.cc
diff --git a/chrome/browser/password_manager/password_store_default.cc b/chrome/browser/password_manager/password_store_default.cc
deleted file mode 100644
index 35de563e23464647202a3643accde313a7e0804e..0000000000000000000000000000000000000000
--- a/chrome/browser/password_manager/password_store_default.cc
+++ /dev/null
@@ -1,61 +0,0 @@
-// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/password_manager/password_store_default.h"
-#include "chrome/browser/webdata/web_data_service.h"
-#include "chrome/common/chrome_constants.h"
-
-#include "base/logging.h"
-#include "base/task.h"
-
-PasswordStoreDefault::PasswordStoreDefault(WebDataService* web_data_service)
- : web_data_service_(web_data_service) {
-}
-
-PasswordStoreDefault::~PasswordStoreDefault() {
- for (PendingRequestMap::const_iterator it = pending_requests_.begin();
- it != pending_requests_.end(); ++it) {
- scoped_ptr<GetLoginsRequest> request(it->second);
- web_data_service_->CancelRequest(it->first);
- }
-}
-
-void PasswordStoreDefault::AddLoginImpl(const PasswordForm& form) {
- web_data_service_->AddLogin(form);
-}
-
-void PasswordStoreDefault::RemoveLoginImpl(const PasswordForm& form) {
- web_data_service_->RemoveLogin(form);
-}
-
-void PasswordStoreDefault::UpdateLoginImpl(const PasswordForm& form) {
- web_data_service_->UpdateLogin(form);
-}
-
-void PasswordStoreDefault::GetLoginsImpl(GetLoginsRequest* request) {
- int web_data_handle = web_data_service_->GetLogins(request->form, this);
- pending_requests_.insert(PendingRequestMap::value_type(
- web_data_handle, request));
-}
-
-void PasswordStoreDefault::OnWebDataServiceRequestDone(
- WebDataService::Handle h,
- const WDTypedResult *result) {
- // Look up this handle in our request map to get the original
- // GetLoginsRequest.
- PendingRequestMap::iterator it(pending_requests_.find(h));
- DCHECK(it != pending_requests_.end());
-
- GetLoginsRequest* request = it->second;
- pending_requests_.erase(it);
-
- DCHECK(result);
- if (!result)
- return;
-
- const WDResult<std::vector<PasswordForm*> >* r =
- static_cast<const WDResult<std::vector<PasswordForm*> >*>(result);
-
- NotifyConsumer(request, r->GetValue());
-}

Powered by Google App Engine
This is Rietveld 408576698