Issue 113860: Make the GUID upper case (so Visual Studio won't try to correct...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113860: Make the GUID upper case (so Visual Studio won't try to correct... (Closed)

Created:
11 years, 7 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai, bradnelson

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the GUID upper case (so Visual Studio won't try to correct it by asking to write out a "modified" chrome.sln). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16951

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/ffmpeg/ffmpeg.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 7 months ago (2009-05-26 21:07:56 UTC) #2

LGTM.

Also, the MSVS generator should probably canonize UUID strings by writing them
in all-uppercase when generating files, if that's how MSVS would want to rewrite
them.

Expand Messages | Collapse Messages