Support for searching bookmarks for IDN....

Support for searching bookmarks for IDN.

The main part of this change is DoesBookmarkContainWords() in
bookmark_utils.cc.  It tries to match a query words to IDN and
%-decoded strings as well as ASCII URL.

BUG=3991
TEST=add a unit test, check for IDN in the search box of Bookmark Manager.

[brettw, 2009-05-27 17:29:44]

LGTM

http://codereview.chromium.org/113815/diff/1/8
File chrome/browser/bookmarks/bookmark_table_model.h (right):

http://codereview.chromium.org/113815/diff/1/8#newcode35
Line 35: const std::wstring& languages);
Can you provide documentation on what "languages" means? It's not clear lust
looking at it.

http://codereview.chromium.org/113815/diff/1/4
File chrome/browser/bookmarks/bookmark_table_model_unittest.cc (right):

http://codereview.chromium.org/113815/diff/1/4#newcode251
Line 251: bookmark_model(), L"c", L""));
I usually prefer std::wstring() instead of L"" since L"" will call the wchar_t
version of the string constructor which will have to do more work computing the
length.

[tkent_google.com, 2009-06-01 04:12:59]

Would you commit this for me please?

http://codereview.chromium.org/113815/diff/1/8
File chrome/browser/bookmarks/bookmark_table_model.h (right):

http://codereview.chromium.org/113815/diff/1/8#newcode35
Line 35: const std::wstring& languages);
On 2009/05/27 17:29:44, brettw wrote:
> Can you provide documentation on what "languages" means? It's not clear lust
> looking at it.

Done.

http://codereview.chromium.org/113815/diff/1/4
File chrome/browser/bookmarks/bookmark_table_model_unittest.cc (right):

http://codereview.chromium.org/113815/diff/1/4#newcode251
Line 251: bookmark_model(), L"c", L""));
On 2009/05/27 17:29:44, brettw wrote:
> I usually prefer std::wstring() instead of L"" since L"" will call the wchar_t
> version of the string constructor which will have to do more work computing
the
> length.

Done.
I changed so for bookmark_utils_unittest.cc too.

[brettw, 2009-06-02 22:15:20]

Checked in as r17435