Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: chrome/browser/bookmarks/bookmark_utils.cc

Issue 113815: Support for searching bookmarks for IDN.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_utils.h ('k') | chrome/browser/bookmarks/bookmark_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_utils.cc
===================================================================
--- chrome/browser/bookmarks/bookmark_utils.cc (revision 17304)
+++ chrome/browser/bookmarks/bookmark_utils.cc (working copy)
@@ -29,6 +29,7 @@
#include "chrome/common/pref_service.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
+#include "net/base/net_util.h"
#include "views/event.h"
using base::Time;
@@ -177,12 +178,16 @@
}
// Returns true if |node|s title or url contains the strings in |words|.
+// |languages| argument is user's accept-language setting to decode IDN.
bool DoesBookmarkContainWords(BookmarkNode* node,
- const std::vector<std::wstring>& words) {
+ const std::vector<std::wstring>& words,
+ const std::wstring& languages) {
return
DoesBookmarkTextContainWords(
l10n_util::ToLower(node->GetTitle()), words) ||
- DoesBookmarkTextContainWords(UTF8ToWide(node->GetURL().spec()), words);
+ DoesBookmarkTextContainWords(UTF8ToWide(node->GetURL().spec()), words) ||
+ DoesBookmarkTextContainWords(net::FormatUrl(
+ node->GetURL(), languages, false, true, NULL, NULL), words);
}
} // namespace
@@ -478,6 +483,7 @@
void GetBookmarksContainingText(BookmarkModel* model,
const std::wstring& text,
size_t max_count,
+ const std::wstring& languages,
std::vector<BookmarkNode*>* nodes) {
std::vector<std::wstring> words;
QueryParser parser;
@@ -488,7 +494,7 @@
TreeNodeIterator<BookmarkNode> iterator(model->root_node());
while (iterator.has_next()) {
BookmarkNode* node = iterator.Next();
- if (node->is_url() && DoesBookmarkContainWords(node, words)) {
+ if (node->is_url() && DoesBookmarkContainWords(node, words, languages)) {
nodes->push_back(node);
if (nodes->size() == max_count)
return;
@@ -496,14 +502,16 @@
}
}
-bool DoesBookmarkContainText(BookmarkNode* node, const std::wstring& text) {
+bool DoesBookmarkContainText(BookmarkNode* node,
+ const std::wstring& text,
+ const std::wstring& languages) {
std::vector<std::wstring> words;
QueryParser parser;
parser.ExtractQueryWords(l10n_util::ToLower(text), &words);
if (words.empty())
return false;
- return (node->is_url() && DoesBookmarkContainWords(node, words));
+ return (node->is_url() && DoesBookmarkContainWords(node, words, languages));
}
void ApplyEditsWithNoGroupChange(BookmarkModel* model,
« no previous file with comments | « chrome/browser/bookmarks/bookmark_utils.h ('k') | chrome/browser/bookmarks/bookmark_utils_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698