Issue 1138006: Fix test return values (otherwise, autotest mistakenly thinks it failed).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1138006: Fix test return values (otherwise, autotest mistakenly thinks it failed). (Closed)

Created:
10 years, 9 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, gauravsh

Visibility:
Public.

Description

Fix test return values (otherwise, autotest mistakenly thinks it failed).

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/platform/vboot_reference/tests/firmware_image_tests.c	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/platform/vboot_reference/tests/kernel_image_tests.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

On 2010/03/23 01:21:16, gauravsh wrote: > I'm assuming this means you now return 0 if ...

10 years, 9 months ago (2010-03-23 01:22:40 UTC) #2

gauravsh

10 years, 9 months ago (2010-03-23 01:25:04 UTC) #3

On Mon, Mar 22, 2010 at 6:22 PM,  <cmasone@chromium.org> wrote:
> On 2010/03/23 01:21:16, gauravsh wrote:
>
>
> I'm assuming this means you now return 0 if all was well?
Yes.

>
> If so, LGTM
>
> http://codereview.chromium.org/1138006
>


-- 
-g

Expand Messages | Collapse Messages