Issue 1138003: Fix code generation for fast smi loops to support parameters as well....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1138003: Fix code generation for fast smi loops to support parameters as well.... (Closed)

Created:
10 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix code generation for fast smi loops to support parameters as well. This change fixes an assert we hit when we recognized a fast smi loop with a parameter as the loop variable. BUG=650 Committed: http://code.google.com/p/v8/source/detail?r=4202

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -19 lines)			Patch
M	src/arm/virtual-frame-arm.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	3 chunks	+22 lines, -18 lines	0 comments	Download
M	src/ia32/virtual-frame-ia32.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/virtual-frame-inl.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/virtual-frame-x64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/compiler/loopcount.js	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM, if comment addressed. http://codereview.chromium.org/1138003/diff/1/4 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1138003/diff/1/4#newcode3663 src/ia32/codegen-ia32.cc:3663: if (slot->type() == Slot::LOCAL) { ...

10 years, 9 months ago (2010-03-22 10:46:22 UTC) #2

fschneider

10 years, 9 months ago (2010-03-22 11:52:52 UTC) #3

http://codereview.chromium.org/1138003/diff/1/4
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/1138003/diff/1/4#newcode3663
src/ia32/codegen-ia32.cc:3663: if (slot->type() == Slot::LOCAL) {
On 2010/03/22 10:46:22, William Hesse wrote:
> Shouldn't this test only be done if info == SMI?
> 

Yes, it should.

Done.

Expand Messages | Collapse Messages