Issue 113783: Factor out SVN-specific methods out of AffectedFile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113783: Factor out SVN-specific methods out of AffectedFile. (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Factor out SVN-specific methods out of AffectedFile. TEST=New unit tests. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16785

Patch Set 1 #

Total comments: 2

Patch Set 2 : 80 cols #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -37 lines)			Patch
	M	presubmit_support.py	View	1	5 chunks	+47 lines, -18 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		5 chunks	+31 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói Sigurðsson

11 years, 7 months ago (2009-05-22 20:17:06 UTC) #2

LGTM with nits

http://codereview.chromium.org/113783/diff/1/2
File presubmit_support.py (right):

http://codereview.chromium.org/113783/diff/1/2#newcode400
Line 400: class SvnAffectedFile(AffectedFile):
add a class pydoc

http://codereview.chromium.org/113783/diff/1/2#newcode411
Line 411: # Retrieve directly from the file system; it is much faster than
querying
+80

Expand Messages | Collapse Messages