Factor out SVN-specific methods out of AffectedFile.

presubmit_support.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.0.1'
 
@@ skipping 306 matching lines @@
       for line in lines:
         line_number += 1
         yield (af, line_number, line)
 
 
 class AffectedFile(object):
   """Representation of a file in a change."""
 
   def __init__(self, path, action, repository_root=''):
     self.path = path
-    self.action = action.strip()
+    self.action = action
     self.repository_root = repository_root
+    self.server_path = None
+    self.is_directory = None
+    self.properties = {}
 
   def ServerPath(self):
     """Returns a path string that identifies the file in the SCM system.
 
     Returns the empty string if the file does not exist in SCM.
     """
-    return gclient.CaptureSVNInfo(self.AbsoluteLocalPath()).get('URL', '')
+    return ""
 
   def LocalPath(self):
     """Returns the path of this file on the local disk relative to client root.
     """
     return normpath(self.path)
 
   def AbsoluteLocalPath(self):
     """Returns the absolute path of this file on the local disk.
     """
     return normpath(os.path.join(self.repository_root, self.LocalPath()))
 
   def IsDirectory(self):
     """Returns true if this object is a directory."""
     path = self.AbsoluteLocalPath()
-    if os.path.exists(path):
-      # Retrieve directly from the file system; it is much faster than querying
-      # subversion, especially on Windows.
-      return os.path.isdir(path)
-    else:
-      return gclient.CaptureSVNInfo(path).get('Node Kind') in ('dir',
-                                                               'directory')
-
-  def SvnProperty(self, property_name):
-    """Returns the specified SVN property of this file, or the empty string
-    if no such property.
-    """
-    return gcl.GetSVNFileProperty(self.AbsoluteLocalPath(), property_name)
+    if self.is_directory is None:
+      self.is_directory = (os.path.exists(path) and
+                           os.path.isdir(path))
+    return self.is_directory
 
   def Action(self):
     """Returns the action on this opened file, e.g. A, M, D, etc."""
+    # TODO(maruel): Somewhat crappy, Could be "A" or "A  +" for svn but
+    # different for other SCM.
     return self.action
 
+  def Property(self, property_name):
+    """Returns the specified SCM property of this file, or None if no such
+    property.
+    """
+    return self.properties.get(property_name, None)
+
   def NewContents(self):
     """Returns an iterator over the lines in the new version of file.
 
     The new version is the file in the user's workspace, i.e. the "right hand
     side".
 
     Contents will be empty if the file is a directory or does not exist.
     """
     if self.IsDirectory():
       return []
@@ skipping 10 matching lines @@
   def OldFileTempPath(self):
     """Returns the path on local disk where the old contents resides.
 
     The old version is the file in depot, i.e. the "left hand side".
     This is a read-only cached copy of the old contents. *DO NOT* try to
     modify this file.
     """
     raise NotImplementedError()  # Implement if/when needed.
 
 
+class SvnAffectedFile(AffectedFile):
+  def ServerPath(self):
+    if self.server_path is None:
+      self.server_path = gclient.CaptureSVNInfo(
+          self.AbsoluteLocalPath()).get('URL', '')
+    return self.server_path
+
+  def IsDirectory(self):
+    path = self.AbsoluteLocalPath()
+    if self.is_directory is None:
+      if os.path.exists(path):
+        # Retrieve directly from the file system; it is much faster than
+        # querying subversion, especially on Windows.
+        self.is_directory = os.path.isdir(path)
+      else:
+        self.is_directory = gclient.CaptureSVNInfo(
+            path).get('Node Kind') in ('dir', 'directory')
+    return self.is_directory
+
+  def Property(self, property_name):
+    if not property_name in self.properties:
+      self.properties[property_name] = gcl.GetSVNFileProperty(
+          self.AbsoluteLocalPath(), property_name)
+    return self.properties[property_name]
+
+
 class GclChange(object):
   """A gcl change. See gcl.ChangeInfo for more info."""
 
   def __init__(self, change_info, repository_root=''):
     self.name = change_info.name
     self.full_description = change_info.description
     self.repository_root = repository_root
 
     # From the description text, build up a dictionary of key/value pairs
     # plus the description minus all key/value or "tag" lines.
     self.description_without_tags = []
     self.tags = {}
     for line in change_info.description.splitlines():
       m = _tag_line_re.match(line)
       if m:
         self.tags[m.group('key')] = m.group('value')
       else:
         self.description_without_tags.append(line)
 
     # Change back to text and remove whitespace at end.
     self.description_without_tags = '\n'.join(self.description_without_tags)
     self.description_without_tags = self.description_without_tags.rstrip()
 
-    self.affected_files = [AffectedFile(info[1], info[0], repository_root) for
-                           info in change_info.files]
+    self.affected_files = [
+        SvnAffectedFile(info[1], info[0].strip(), repository_root)
+        for info in change_info.files
+    ]
 
   def Change(self):
     """Returns the change name."""
     return self.name
 
   def Changelist(self):
     """Synonym for Change()."""
     return self.Change()
 
   def DescriptionText(self):
@@ skipping 111 matching lines @@
 
       checked_dirs[dir] = ''
       if dir in ['', '.']:
         break
       else:
         dir = os.path.dirname(dir)
   return presubmit_files
 
 
 class PresubmitExecuter(object):
-
   def __init__(self, change_info, committing):
     """
     Args:
       change_info: The ChangeInfo object for the change.
       committing: True if 'gcl commit' is running, False if 'gcl upload' is.
     """
     self.change = GclChange(change_info, gcl.GetRepositoryRoot())
     self.committing = committing
 
   def ExecPresubmitScript(self, script_text, presubmit_path):
@@ skipping 146 matching lines @@
   return not DoPresubmitChecks(gcl.ChangeInfo(name='temp', files=files),
                                options.commit,
                                options.verbose,
                                sys.stdout,
                                sys.stdin,
                                default_presubmit=None)
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))