Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11377140: re-re-land of https://codereview.chromium.org/11364053/ (Closed)

Created:
8 years, 1 month ago by scottmg
Modified:
8 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tburkard+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, gavinp+prer_chromium.org, dominich+watch_chromium.org, darin-cc_chromium.org, James Su, mmenke
Visibility:
Public.

Description

re-re-land of https://codereview.chromium.org/11364053/ First attempt here: https://codereview.chromium.org/11364053/ : failed linux_chromeos_asan Second attempt here: http://codereview.chromium.org/11362216/ : collided with renames in http://crrev.com/167418 This cl is the same as the second attempt, with the namespaces and includes updated for file renames. TBR=ben@chromium.org BUG=128578 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167547

Patch Set 1 #

Patch Set 2 : rebase, fix prototype, fix include #

Patch Set 3 : more renames\! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -223 lines) Patch
M ash/shell.h View 4 chunks +4 lines, -2 lines 0 comments Download
M ash/shell.cc View 3 chunks +8 lines, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/shell_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ash/wm/stacking_controller.h View 3 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/stacking_controller.cc View 1 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/aura/stacking_client_aura.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/aura/stacking_client_aura.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/shell_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_stacking_client_ash.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/shell_stacking_client_ash.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/aura/client/stacking_client.h View 1 chunk +7 lines, -11 lines 0 comments Download
M ui/aura/client/stacking_client.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/desktop/desktop_stacking_client.h View 1 2 1 chunk +0 lines, -65 lines 0 comments Download
M ui/aura/desktop/desktop_stacking_client.cc View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
M ui/aura/test/test_stacking_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/test/test_stacking_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/window.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 chunks +0 lines, -29 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_stacking_client.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_stacking_client.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
lgtm imma let you finish, but http://codereview.chromium.org/11369220/ was the best desktop-aura related file move of ...
8 years, 1 month ago (2012-11-13 20:44:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11377140/6083
8 years, 1 month ago (2012-11-13 21:57:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11377140/17001
8 years, 1 month ago (2012-11-13 22:26:44 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 01:10:49 UTC) #4 
Change committed as 167547

Powered by Google App Engine
This is Rietveld 408576698