chrome/browser/ui/browser_commands.cc - Issue 11377140: re-re-land of https://codereview.chromium.org/11364053/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 11377140: re-re-land of https://codereview.chromium.org/11364053/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more renames\! Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index d5f3744129222c0f90b6ebd6e6f183ab6a438ca8..a01c79150a1eb6d1de4d17364e0f898a14a80a26 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -306,6 +306,10 @@ void NewEmptyWindow(Profile* profile) {

}

Browser* OpenEmptyWindow(Profile* profile, HostDesktopType desktop_type) {

+ // TODO(scottmg): http://crbug.com/128578

+ // This is necessary because WebContentsViewAura doesn't have enough context

+ // to get the right StackingClient (and therefore parent window) otherwise.

+ ScopedForceDesktopType force_desktop_type(desktop_type);

Browser* browser = new Browser(

Browser::CreateParams(Browser::TYPE_TABBED, profile, desktop_type));

AddBlankTabAt(browser, -1, true);