Issue 113761: Add missing file to change 2030. x64/assembler-x64-inl.h was not uploaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113761: Add missing file to change 2030. x64/assembler-x64-inl.h was not uploaded. (Closed)

Created:
11 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, iposva, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add missing file to change 2030. x64/assembler-x64-inl.h was not uploaded. Committed: http://code.google.com/p/v8/source/detail?r=2031

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -13 lines)			Patch
	M	src/x64/assembler-x64-inl.h	View		2 chunks	+33 lines, -13 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Add missing file to change. See disussion of change 115571 (http://codereview.chromium.org/115571) for more context about ...

11 years, 7 months ago (2009-05-22 08:31:20 UTC) #1

iposva

11 years, 7 months ago (2009-05-22 15:50:23 UTC) #3

http://codereview.chromium.org/113761/diff/1/2
File src/x64/assembler-x64-inl.h (right):

http://codereview.chromium.org/113761/diff/1/2#newcode44
Line 44: *pc_++ = (x)
Is there any particular reason why this has to be a macro? Why not define a
inline void emit(byte x) in the assembler_x64.h file? That would be much
cleaner.

Thanks!

Expand Messages | Collapse Messages