Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5864)

Unified Diff: chrome/browser/download/download_uitest.cc

Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/crash_recovery_uitest.cc ('k') | chrome/browser/download/save_page_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_uitest.cc
===================================================================
--- chrome/browser/download/download_uitest.cc (revision 17078)
+++ chrome/browser/download/download_uitest.cc (working copy)
@@ -124,14 +124,14 @@
// Complete sending the request. We do this by loading a second URL in a
// separate tab.
- scoped_ptr<BrowserProxy> window(automation()->GetBrowserWindow(0));
+ scoped_refptr<BrowserProxy> window(automation()->GetBrowserWindow(0));
EXPECT_TRUE(window->AppendTab(GURL(
URLRequestSlowDownloadJob::kFinishDownloadUrl)));
EXPECT_EQ(2, GetTabCount());
// TODO(tc): check download status text
// Make sure the download shelf is showing.
- scoped_ptr<TabProxy> dl_tab(window->GetTab(0));
+ scoped_refptr<TabProxy> dl_tab(window->GetTab(0));
ASSERT_TRUE(dl_tab.get());
EXPECT_TRUE(WaitForDownloadShelfVisible(dl_tab.get()));
}
@@ -170,7 +170,7 @@
CleanUpDownload(file);
- scoped_ptr<TabProxy> tab_proxy(GetActiveTab());
+ scoped_refptr<TabProxy> tab_proxy(GetActiveTab());
ASSERT_TRUE(tab_proxy.get());
EXPECT_TRUE(WaitForDownloadShelfVisible(tab_proxy.get()));
}
@@ -196,7 +196,7 @@
if (file_util::PathExists(file_path))
ASSERT_TRUE(file_util::Delete(file_path, false));
- scoped_ptr<TabProxy> tab_proxy(GetActiveTab());
+ scoped_refptr<TabProxy> tab_proxy(GetActiveTab());
ASSERT_TRUE(tab_proxy.get());
EXPECT_FALSE(WaitForDownloadShelfVisible(tab_proxy.get()));
}
@@ -219,7 +219,7 @@
CleanUpDownload(download_file, file);
// Ensure the download shelf is visible on the current tab.
- scoped_ptr<TabProxy> tab_proxy(GetActiveTab());
+ scoped_refptr<TabProxy> tab_proxy(GetActiveTab());
ASSERT_TRUE(tab_proxy.get());
EXPECT_TRUE(WaitForDownloadShelfVisible(tab_proxy.get()));
}
« no previous file with comments | « chrome/browser/crash_recovery_uitest.cc ('k') | chrome/browser/download/save_page_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698