chrome/browser/crash_recovery_uitest.cc - Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/crash_recovery_uitest.cc

Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/crash_recovery_uitest.cc

===================================================================

--- chrome/browser/crash_recovery_uitest.cc (revision 17078)

+++ chrome/browser/crash_recovery_uitest.cc (working copy)

@@ -27,7 +27,7 @@

std::wstring title1 = GetActiveTabTitle();

- scoped_ptr<TabProxy> tab(GetActiveTab());

+ scoped_refptr<TabProxy> tab(GetActiveTab());

// Cause the renderer to crash.

expected_crashes_ = 1;

@@ -61,7 +61,7 @@

const std::wstring title(L"Title Of Awesomeness");

EXPECT_EQ(title, GetActiveTabTitle());

- scoped_ptr<TabProxy> tab(GetActiveTab());

+ scoped_refptr<TabProxy> tab(GetActiveTab());

// Cause the renderer to crash.

expected_crashes_ = 1;

@@ -70,7 +70,7 @@

// Wait for the browser to notice the renderer crash.

PlatformThread::Sleep(1000);

- scoped_ptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));

+ scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));

ASSERT_TRUE(browser_proxy->AppendTab(url));

// Ensure the title of the new tab is updated, indicating that the navigation

« no previous file with comments | « chrome/browser/browser_uitest.cc ('k') | chrome/browser/download/download_uitest.cc » ('j') | no next file with comments »