Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4228)

Unified Diff: chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/printing_layout_uitest.cc ('k') | chrome/browser/session_history_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
===================================================================
--- chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc (revision 17078)
+++ chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc (working copy)
@@ -67,8 +67,8 @@
EXPECT_EQ(1, GetTabCount());
// Make sure the download shelf is not showing.
- scoped_ptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
- scoped_ptr<TabProxy> dl_tab(browser->GetTab(0));
+ scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
+ scoped_refptr<TabProxy> dl_tab(browser->GetTab(0));
ASSERT_TRUE(dl_tab.get());
bool visible = false;
@@ -91,9 +91,9 @@
HTTPTestServer::CreateServer(kDocRoot, NULL);
ASSERT_TRUE(NULL != server.get());
- scoped_ptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
+ scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
EXPECT_TRUE(browser_proxy.get());
- scoped_ptr<TabProxy> tab(browser_proxy->GetActiveTab());
+ scoped_refptr<TabProxy> tab(browser_proxy->GetActiveTab());
tab->NavigateToURL(server->TestServerPageW(
L"files/sync_xmlhttprequest.html"));
@@ -111,9 +111,9 @@
HTTPTestServer::CreateServer(kDocRoot, NULL);
ASSERT_TRUE(NULL != server.get());
- scoped_ptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
+ scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
EXPECT_TRUE(browser_proxy.get());
- scoped_ptr<TabProxy> tab(browser_proxy->GetActiveTab());
+ scoped_refptr<TabProxy> tab(browser_proxy->GetActiveTab());
tab->NavigateToURL(server->TestServerPageW(
L"files/sync_xmlhttprequest_disallowed.html"));
@@ -134,9 +134,9 @@
HTTPTestServer::CreateServer(kDocRoot, NULL);
ASSERT_TRUE(NULL != server.get());
- scoped_ptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
+ scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
EXPECT_TRUE(browser_proxy.get());
- scoped_ptr<TabProxy> tab(browser_proxy->GetActiveTab());
+ scoped_refptr<TabProxy> tab(browser_proxy->GetActiveTab());
tab->NavigateToURL(
server->TestServerPageW(L"files/sync_xmlhttprequest_during_unload.html"));
@@ -169,9 +169,9 @@
HTTPTestServer::CreateServer(kDocRoot, NULL);
ASSERT_TRUE(NULL != server.get());
- scoped_ptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
+ scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
EXPECT_TRUE(browser_proxy.get());
- scoped_ptr<TabProxy> tab(browser_proxy->GetActiveTab());
+ scoped_refptr<TabProxy> tab(browser_proxy->GetActiveTab());
GURL url(server->TestServerPageW(L"files/onunload_cookie.html"));
tab->NavigateToURL(url);
@@ -209,9 +209,9 @@
if (in_process_renderer())
return;
- scoped_ptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
+ scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
EXPECT_TRUE(browser_proxy.get());
- scoped_ptr<TabProxy> tab(browser_proxy->GetActiveTab());
+ scoped_refptr<TabProxy> tab(browser_proxy->GetActiveTab());
// Cause the renderer to crash.
expected_crashes_ = 1;
@@ -229,9 +229,9 @@
// Tests that cross-site navigations work when the new page does not go through
// the BufferedEventHandler (e.g., non-http{s} URLs). (Bug 1225872)
TEST_F(ResourceDispatcherTest, CrossSiteNavigationNonBuffered) {
- scoped_ptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
+ scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
EXPECT_TRUE(browser_proxy.get());
- scoped_ptr<TabProxy> tab(browser_proxy->GetActiveTab());
+ scoped_refptr<TabProxy> tab(browser_proxy->GetActiveTab());
// Start with an HTTP page.
CheckTitleTest(L"content-sniffer-test0.html",
@@ -258,9 +258,9 @@
HTTPTestServer::CreateServer(kDocRoot, NULL);
ASSERT_TRUE(NULL != server.get());
- scoped_ptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
+ scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
EXPECT_TRUE(browser_proxy.get());
- scoped_ptr<TabProxy> tab(browser_proxy->GetActiveTab());
+ scoped_refptr<TabProxy> tab(browser_proxy->GetActiveTab());
GURL url(server->TestServerPageW(L"files/onunload_cookie.html"));
tab->NavigateToURL(url);
« no previous file with comments | « chrome/browser/printing/printing_layout_uitest.cc ('k') | chrome/browser/session_history_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698