chrome/browser/printing/printing_layout_uitest.cc - Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/printing_layout_uitest.cc

Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/metrics_service_uitest.cc ('k') | chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/printing_layout_uitest.cc

===================================================================

--- chrome/browser/printing/printing_layout_uitest.cc (revision 17078)

+++ chrome/browser/printing/printing_layout_uitest.cc (working copy)

@@ -219,7 +219,7 @@

protected:

void PrintNowTab() {

- scoped_ptr<TabProxy> tab_proxy(GetActiveTab());

+ scoped_refptr<TabProxy> tab_proxy(GetActiveTab());

ASSERT_TRUE(tab_proxy.get());

if (!tab_proxy.get())

return;

@@ -566,7 +566,7 @@

ASSERT_TRUE(NULL != server.get());

{

- scoped_ptr<TabProxy> tab_proxy(GetActiveTab());

+ scoped_refptr<TabProxy> tab_proxy(GetActiveTab());

ASSERT_TRUE(tab_proxy.get());

bool is_timeout = true;

GURL url = server->TestServerPage("files/printing/popup_delayed_print.htm");

@@ -601,7 +601,7 @@

ASSERT_TRUE(NULL != server.get());

{

- scoped_ptr<TabProxy> tab_proxy(GetActiveTab());

+ scoped_refptr<TabProxy> tab_proxy(GetActiveTab());

ASSERT_TRUE(tab_proxy.get());

GURL url = server->TestServerPage("files/printing/iframe.htm");

EXPECT_EQ(AUTOMATION_MSG_NAVIGATION_SUCCESS,