Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3796)

Unified Diff: chrome/browser/metrics/metrics_service_uitest.cc

Issue 113722: Make automation proxy objects to ref_counted. That allows to process async no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/login_prompt_uitest.cc ('k') | chrome/browser/printing/printing_layout_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service_uitest.cc
===================================================================
--- chrome/browser/metrics/metrics_service_uitest.cc (revision 17078)
+++ chrome/browser/metrics/metrics_service_uitest.cc (working copy)
@@ -24,7 +24,7 @@
class MetricsServiceTest : public UITest {
public:
- MetricsServiceTest() : UITest(), window_(NULL) {
+ MetricsServiceTest() : UITest() {
// We need to show the window so web content type tabs load.
show_window_ = true;
}
@@ -32,7 +32,7 @@
// Open a few tabs of random content
void OpenTabs() {
window_ = automation()->GetBrowserWindow(0);
- ASSERT_TRUE(window_);
+ ASSERT_TRUE(window_.get());
FilePath page1_path;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &page1_path));
@@ -57,12 +57,12 @@
}
virtual void TearDown() {
- delete window_;
+ window_ = NULL;
UITest::TearDown();
}
protected:
- BrowserProxy* window_;
+ scoped_refptr<BrowserProxy> window_;
};
TEST_F(MetricsServiceTest, CloseRenderersNormally) {
@@ -88,7 +88,7 @@
OpenTabs();
// kill the process for one of the tabs
- scoped_ptr<TabProxy> tab(window_->GetTab(1));
+ scoped_refptr<TabProxy> tab(window_->GetTab(1));
ASSERT_TRUE(tab.get());
int process_id = 0;
ASSERT_TRUE(tab->GetProcessID(&process_id));
« no previous file with comments | « chrome/browser/login_prompt_uitest.cc ('k') | chrome/browser/printing/printing_layout_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698