[Sanity Review] cc: Mark an event has not-handled if it didn't cause a scroll

cc: If an event did not actually do any scroll in scrollBy, then mark the event as not-handled.

BUG=none

[sadrul, 2012-11-13 23:25:41]

Webkit part of the change: http://codereview.chromium.org/11365238/

[danakj, 2012-11-14 01:55:32]

http://codereview.chromium.org/11369231/diff/1/Source/Platform/chromium/publi...
File Source/Platform/chromium/public/WebInputHandlerClient.h (right):

http://codereview.chromium.org/11369231/diff/1/Source/Platform/chromium/publi...
Source/Platform/chromium/public/WebInputHandlerClient.h:56: virtual bool
scrollBy(WebPoint, WebSize) = 0;
You should add a comment about the return value.

Is a bool always going to be enough? Should you maybe return the WebSize
remaining of what was not scrolled (say you scroll to the bottom of the page mid
scroll?)

See similar code for the pageScaleViewport in layer_tree_host_impl for a
precedent. That's why I thought of it.

[rjkroege, 2012-11-14 16:58:41]

On 2012/11/14 01:55:32, danakj wrote:
>
http://codereview.chromium.org/11369231/diff/1/Source/Platform/chromium/publi...
> File Source/Platform/chromium/public/WebInputHandlerClient.h (right):
> 
>
http://codereview.chromium.org/11369231/diff/1/Source/Platform/chromium/publi...
> Source/Platform/chromium/public/WebInputHandlerClient.h:56: virtual bool
> scrollBy(WebPoint, WebSize) = 0;
> You should add a comment about the return value.
> 
> Is a bool always going to be enough? Should you maybe return the WebSize
> remaining of what was not scrolled (say you scroll to the bottom of the page
mid
> scroll?)
> 

That's an awesome idea. +1

> See similar code for the pageScaleViewport in layer_tree_host_impl for a
> precedent. That's why I thought of it.

[rjkroege, 2012-11-14 17:00:26]

https://codereview.chromium.org/11369231/diff/1/Source/Platform/chromium/publ...
File Source/Platform/chromium/public/WebInputHandlerClient.h (right):

https://codereview.chromium.org/11369231/diff/1/Source/Platform/chromium/publ...
Source/Platform/chromium/public/WebInputHandlerClient.h:56: virtual bool
scrollBy(WebPoint, WebSize) = 0;
On 2012/11/14 01:55:32, danakj wrote:
> You should add a comment about the return value.
> 
> Is a bool always going to be enough? Should you maybe return the WebSize
> remaining of what was not scrolled (say you scroll to the bottom of the page
mid
> scroll?)
> 
> See similar code for the pageScaleViewport in layer_tree_host_impl for a
> precedent. That's why I thought of it.

And: it would be nice to use enums for these sorts of things because (at least
I) can't remember what processed means. :-)