[Sanity Review] cc: Mark an event has not-handled if it didn't cause a scroll

Source/Platform/chromium/public/WebInputHandlerClient.h

Index: Source/Platform/chromium/public/WebInputHandlerClient.h
diff --git a/Source/Platform/chromium/public/WebInputHandlerClient.h b/Source/Platform/chromium/public/WebInputHandlerClient.h
index 1bef205c4eb4514ca58f6d323902428f6231c243..c9f2a0c83b6c38fa136037e30f22356cd6fc0038 100644
--- a/Source/Platform/chromium/public/WebInputHandlerClient.h
+++ b/Source/Platform/chromium/public/WebInputHandlerClient.h
@@ -53,7 +53,7 @@ public:
     // there is no room to move the layer in the requested direction, its first
     // ancestor layer that can be scrolled will be moved instead. Should only be
     // called if scrollBegin() returned ScrollStarted.
-    virtual void scrollBy(WebPoint, WebSize) = 0;
+    virtual bool scrollBy(WebPoint, WebSize) = 0;

[danakj, 2012/11/14 01:55:32]

You should add a comment about the return value.

Is a bool always going to be enough? Should you maybe return the WebSize
remaining of what was not scrolled (say you scroll to the bottom of the page mid
scroll?)

See similar code for the pageScaleViewport in layer_tree_host_impl for a
precedent. That's why I thought of it.

[rjkroege, 2012/11/14 17:00:26]

And: it would be nice to use enums for these sorts of things because (at least
I) can't remember what processed means. :-)

 
     // Stop scrolling the selected layer. Should only be called if scrollBegin()
     // returned ScrollStarted.