Issue 113650: Fix error printing in gcl.GetRepositoryRoot() and fix its unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113650: Fix error printing in gcl.GetRepositoryRoot() and fix its unit tests. (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix error printing in gcl.GetRepositoryRoot() and fix its unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16499

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -15 lines)			Patch
	M	gcl.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/gcl_unittest.py	View		4 chunks	+32 lines, -13 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 7 months ago (2009-05-20 18:26:57 UTC) #3

http://codereview.chromium.org/113650/diff/1/3
File tests/gcl_unittest.py (right):

http://codereview.chromium.org/113650/diff/1/3#newcode91
Line 91: gcl.gclient.CaptureSVNInfo("/bleh/prout",
print_error=False).AndReturn(result)
80 chars

Expand Messages | Collapse Messages