Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gcl.py

Issue 113650: Fix error printing in gcl.GetRepositoryRoot() and fix its unit tests. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/gcl_unittest.py » ('j') | tests/gcl_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index d8c09afa91d4f272b217dcf84ed9730a8e63f9ac..2911b1212b5ce382e4026b583e91cf5399947d3c 100755
--- a/gcl.py
+++ b/gcl.py
@@ -101,8 +101,8 @@ def GetRepositoryRoot():
repository_root = os.getcwd()
while True:
parent = os.path.dirname(repository_root)
- if (gclient.CaptureSVNInfo(parent).get("Repository Root") !=
- cur_dir_repo_root):
+ if (gclient.CaptureSVNInfo(parent, print_error=False).get(
+ "Repository Root") != cur_dir_repo_root):
break
repository_root = parent
return repository_root
« no previous file with comments | « no previous file | tests/gcl_unittest.py » ('j') | tests/gcl_unittest.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698