Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: runtime/bin/bin.gypi

Issue 11362132: Change dart_no_snapshot to run native extensions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/bin.gypi
diff --git a/runtime/bin/bin.gypi b/runtime/bin/bin.gypi
index 07321dc8934ad07a561c71b0873edbd53745369c..41d0078ce90b40bd3d5c330e2136a7ba6ad76955 100644
--- a/runtime/bin/bin.gypi
+++ b/runtime/bin/bin.gypi
@@ -322,6 +322,9 @@
'../vm/debugger_api_impl.cc',
'<(version_cc_file)',
],
+ 'defines': [
+ 'DART_SHARED_LIB',
Mads Ager (google) 2012/11/07 10:16:27 This looks wrong. 'type': 'static_library' 'defi
Bill Hesse 2012/11/07 11:23:26 The only effect of DART_SHARED_LIB is to use _decl
Mads Ager (google) 2012/11/07 11:52:00 OK. This looked weird because of that naming. Add
Ivan Posva 2012/11/08 20:32:12 Siva and I discussed earlier today whether we shou
+ ],
},
{
# Completely statically linked binary for generating snapshots.
@@ -472,6 +475,13 @@
'link_settings': {
'libraries': [ '-lws2_32.lib', '-lRpcrt4.lib' ],
},
+ # Generate an import library on Windows, by exporting a function.
+ # Extensions use this import library to link to the API in dart.exe.
Ivan Posva 2012/11/08 20:32:12 This is actually dart_no_snapshot.exe. Can you als
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'AdditionalOptions': [ '/EXPORT:Dart_True' ],
+ },
+ },
}]],
},
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698