Issue 11360237: Use separate WaitableEvents in BlockingUrlProtocol for signalling abort versus read complete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11360237: Use separate WaitableEvents in BlockingUrlProtocol for signalling abort versus read complete. (Closed)

Created:
8 years, 1 month ago by scherkus (not reviewing)

Modified:
8 years, 1 month ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use separate WaitableEvents in BlockingUrlProtocol for signalling abort versus read complete. Previously two separate threads were updating last_bytes_read_ in an unsafe manner. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167576

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -30 lines)			Patch
M	media/filters/blocking_url_protocol.h	View	2	3 chunks	+3 lines, -12 lines	0 comments	Download
M	media/filters/blocking_url_protocol.cc	View	1 2	4 chunks	+15 lines, -10 lines	0 comments	Download
M	media/filters/blocking_url_protocol_unittest.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/11360237/4001

8 years, 1 month ago (2012-11-13 23:55:41 UTC) #3

Change committed as 167576

Expand Messages | Collapse Messages