Issue 11358033: Clean Up: Remove mozc.candidate attachment field handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11358033: Clean Up: Remove mozc.candidate attachment field handling. (Closed)

Created:
8 years, 1 month ago by Seigo Nonaka

Modified:
8 years, 1 month ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, hsumita

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean Up: Remove mozc.candidate attachment field handling. With new Mozc candidates structure, mozc.candidate attachment field is no longer necessary. show_window_at_composition should be handled instead. BUG=129403 TEST=ran chromeos_unittests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165911

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -31 lines)			Patch
M	chromeos/dbus/ibus/ibus_lookup_table.h	View	3 chunks	+6 lines, -12 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_lookup_table.cc	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_lookup_table_unittest.cc	View	3 chunks	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11358033/1

8 years, 1 month ago (2012-11-05 05:29:04 UTC) #3

Change committed as 165911

Expand Messages | Collapse Messages