Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: build/mac/build_app_dmg

Issue 113555: Adding a general script to fetch values from the BRANDING files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/mac/build_app_dmg
===================================================================
--- build/mac/build_app_dmg (revision 16366)
+++ build/mac/build_app_dmg (working copy)
@@ -22,24 +22,18 @@
PKG_DMG="${TOP}/build/mac/pkg-dmg"
BUILD_BRANDING=$1
-if [ "${BUILD_BRANDING}" == "Chromium" ]; then
- APP_NAME="Chromium"
- DMG_NAME="Chromium.dmg"
-elif [ "${BUILD_BRANDING}" == "Chrome" ]; then
- APP_NAME="Google Chrome"
- DMG_NAME="GoogleChrome.dmg"
-else
- echo "error: unknown branding: ${BUILD_BRANDING}" >&2
- exit 1
-fi
+# show things as we run them
+set -x
+
+BRAND_SCRIPT="${TOP}/build/branding_value.sh"
Mark Mentovai 2009/05/19 13:57:14 I don't think you need this in the "set -x" sectio
+APP_NAME=$("${BRAND_SCRIPT}" "${BUILD_BRANDING}" PRODUCT_FULLNAME)
Mark Mentovai 2009/05/19 13:57:14 On the other hand, this can stay in the "set -x" s
+DMG_NAME=$(echo "${APP_NAME}" | sed "s/ //g")
+
SRC_APP_PATH="${BUILT_PRODUCTS_DIR}/${APP_NAME}.app"
VOL_NAME="${APP_NAME}"
DST_DMG_PATH="${BUILT_PRODUCTS_DIR}/${DMG_NAME}"
-# show things as we run them
-set -x
-
# Call the real working
"${PKG_DMG}" --source /var/empty \
--target "${DST_DMG_PATH}" \
« no previous file with comments | « build/branding_value.sh ('k') | build/mac/dump_app_syms » ('j') | build/mac/tweak_app_infoplist » ('J')

Powered by Google App Engine
This is Rietveld 408576698