Adding a general script to fetch values from the BRANDING files.

build/mac/build_app_dmg

 #!/bin/sh
 
 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Normally you don't want to build a dmg out of a debug build.
 if [ "${CONFIGURATION}" != "Release" ] ; then
   echo "warning: building dmg in non-release mode" >&2
 fi
 
 # Make sure we got the branding passed to us
 if [ $# -ne 1 ]; then
   echo "error: missing branding as an argument" >&2
   exit 1
 fi
 
 # fail on anything from here out
 set -e
 
 TOP="${SRCROOT}/.."
 PKG_DMG="${TOP}/build/mac/pkg-dmg"
 
 BUILD_BRANDING=$1
-if [ "${BUILD_BRANDING}" == "Chromium" ]; then
-  APP_NAME="Chromium"
-  DMG_NAME="Chromium.dmg"
-elif [ "${BUILD_BRANDING}" == "Chrome" ]; then
-  APP_NAME="Google Chrome"
-  DMG_NAME="GoogleChrome.dmg"
-else
-  echo "error: unknown branding: ${BUILD_BRANDING}" >&2
-  exit 1
-fi
+
+# show things as we run them
+set -x
+
+BRAND_SCRIPT="${TOP}/build/branding_value.sh"

[Mark Mentovai, 2009/05/19 13:57:14]

I don't think you need this in the "set -x" section, it seems more like it
belongs with PKG_DMG=.

+APP_NAME=$("${BRAND_SCRIPT}" "${BUILD_BRANDING}" PRODUCT_FULLNAME)

[Mark Mentovai, 2009/05/19 13:57:14]

On the other hand, this can stay in the "set -x" section, and should be more
than enough to share the value of BRAND_SCRIPT.

+DMG_NAME=$(echo "${APP_NAME}" | sed "s/ //g")
 
 SRC_APP_PATH="${BUILT_PRODUCTS_DIR}/${APP_NAME}.app"
 VOL_NAME="${APP_NAME}"
 DST_DMG_PATH="${BUILT_PRODUCTS_DIR}/${DMG_NAME}"
 
-# show things as we run them
-set -x
-
 # Call the real working
 "${PKG_DMG}" --source /var/empty \
              --target "${DST_DMG_PATH}" \
              --format UDBZ \
              --volname "${VOL_NAME}" \
              --tempdir "${TEMP_DIR}" \
              --copy "${SRC_APP_PATH}/:/${APP_NAME}.app/"