Adding a general script to fetch values from the BRANDING files.

build/mac/build_app_dmg

Index: build/mac/build_app_dmg
===================================================================
--- build/mac/build_app_dmg	(revision 16366)
+++ build/mac/build_app_dmg	(working copy)
@@ -22,24 +22,18 @@
 PKG_DMG="${TOP}/build/mac/pkg-dmg"
 
 BUILD_BRANDING=$1
-if [ "${BUILD_BRANDING}" == "Chromium" ]; then
-  APP_NAME="Chromium"
-  DMG_NAME="Chromium.dmg"
-elif [ "${BUILD_BRANDING}" == "Chrome" ]; then
-  APP_NAME="Google Chrome"
-  DMG_NAME="GoogleChrome.dmg"
-else
-  echo "error: unknown branding: ${BUILD_BRANDING}" >&2
-  exit 1
-fi
 
+# show things as we run them
+set -x
+
+BRAND_SCRIPT="${TOP}/build/branding_value.sh"

[Mark Mentovai, 2009/05/19 13:57:14]

I don't think you need this in the "set -x" section, it seems more like it
belongs with PKG_DMG=.

+APP_NAME=$("${BRAND_SCRIPT}" "${BUILD_BRANDING}" PRODUCT_FULLNAME)

[Mark Mentovai, 2009/05/19 13:57:14]

On the other hand, this can stay in the "set -x" section, and should be more
than enough to share the value of BRAND_SCRIPT.

+DMG_NAME=$(echo "${APP_NAME}" | sed "s/ //g")
+
 SRC_APP_PATH="${BUILT_PRODUCTS_DIR}/${APP_NAME}.app"
 VOL_NAME="${APP_NAME}"
 DST_DMG_PATH="${BUILT_PRODUCTS_DIR}/${DMG_NAME}"
 
-# show things as we run them
-set -x
-
 # Call the real working
 "${PKG_DMG}" --source /var/empty \
              --target "${DST_DMG_PATH}" \