Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/mac/dump_app_syms

Issue 113555: Adding a general script to fetch values from the BRANDING files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/mac/build_app_dmg ('K') | « build/mac/build_app_dmg ('k') | build/mac/tweak_app_infoplist » ('j') | build/mac/tweak_app_infoplist » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac/dump_app_syms
===================================================================
--- build/mac/dump_app_syms (revision 16366)
+++ build/mac/dump_app_syms (working copy)
@@ -19,15 +19,9 @@
TOP="${SRCROOT}/.."
BUILD_BRANDING=$1
-if [ "${BUILD_BRANDING}" == "Chromium" ]; then
- SRC_APP_NAME="Chromium"
-elif [ "${BUILD_BRANDING}" == "Chrome" ]; then
- SRC_APP_NAME="Google Chrome"
-else
- echo "error: unknown branding: ${BUILD_BRANDING}" >&2
- exit 1
-fi
+BRAND_SCRIPT="${TOP}/build/branding_value.sh"
+SRC_APP_NAME=$("${BRAND_SCRIPT}" "${BUILD_BRANDING}" PRODUCT_FULLNAME)
. "${TOP}/chrome/VERSION"
BREAKPAD_DUMP_SYMS="${BUILT_PRODUCTS_DIR}/dump_syms"
« build/mac/build_app_dmg ('K') | « build/mac/build_app_dmg ('k') | build/mac/tweak_app_infoplist » ('j') | build/mac/tweak_app_infoplist » ('J')

Powered by Google App Engine
This is Rietveld 408576698