Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 113548: Fix a crash in the unittests caused by the fact that the order of... (Closed)

Created:
11 years, 7 months ago by Nicolas Sylvain
Modified:
9 years, 7 months ago
Reviewers:
ananta
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix a crash in the unittests caused by the fact that the order of compilation of the files has changed. Some tests were assuming that g_nt was already defined. 2/3 of the tests were calling SetupNtdllImports(), so I made the rest call that too. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M sandbox/src/policy_low_level_unittest.cc View 10 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Sylvain
11 years, 7 months ago (2009-05-18 21:01:04 UTC) #1
ananta
11 years, 7 months ago (2009-05-18 21:04:00 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698