Fix a crash in the unittests caused by the fact that the order of...

sandbox/src/policy_low_level_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/src/policy_engine_params.h"
 #include "sandbox/src/policy_engine_processor.h"
 #include "sandbox/src/policy_low_level.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #define POLPARAMS_BEGIN(x) sandbox::ParameterSet x[] = {
 #define POLPARAM(p) sandbox::ParamPickerMake(p),
 #define POLPARAMS_END }
 
 namespace sandbox {
 
+bool SetupNtdllImports();
+
 // Testing that we allow opcode generation on valid string patterns.
 TEST(PolicyEngineTest, StringPatternsOK) {
+  SetupNtdllImports();
   PolicyRule pr(ASK_BROKER);
   EXPECT_TRUE(pr.AddStringMatch(IF, 0, L"c:\\adobe\\ver??\\", CASE_SENSITIVE));
   EXPECT_TRUE(pr.AddStringMatch(IF, 0, L"*.tmp", CASE_SENSITIVE));
   EXPECT_TRUE(pr.AddStringMatch(IF, 0, L"c:\\*.doc", CASE_SENSITIVE));
   EXPECT_TRUE(pr.AddStringMatch(IF, 0, L"c:\\windows\\*", CASE_SENSITIVE));
   EXPECT_TRUE(pr.AddStringMatch(IF, 0, L"d:\\adobe\\acrobat.exe",
                                 CASE_SENSITIVE));
 }
 
 // Testing that we signal invalid string patterns.
 TEST(PolicyEngineTest, StringPatternsBAD) {
+  SetupNtdllImports();
   PolicyRule pr(ASK_BROKER);
   EXPECT_FALSE(pr.AddStringMatch(IF, 0, L"one**two", CASE_SENSITIVE));
   EXPECT_FALSE(pr.AddStringMatch(IF, 0, L"**three", CASE_SENSITIVE));
   EXPECT_FALSE(pr.AddStringMatch(IF, 0, L"five?six*?seven", CASE_SENSITIVE));
   EXPECT_FALSE(pr.AddStringMatch(IF, 0, L"eight?*nine", CASE_SENSITIVE));
 }
 
 // Helper function to allocate space (on the heap) for policy.
 PolicyGlobal* MakePolicyMemory() {
   const size_t kTotalPolicySz = 4096*8;
   char* mem = new char[kTotalPolicySz];
   memset(mem, 0, kTotalPolicySz);
   PolicyGlobal* policy = reinterpret_cast<PolicyGlobal*>(mem);
   policy->data_size = kTotalPolicySz - sizeof(PolicyGlobal);
   return policy;
 }
 
 // The simplest test using LowLevelPolicy it should test a single opcode which
 // does a exact string comparison.
 TEST(PolicyEngineTest, SimpleStrMatch) {
+  SetupNtdllImports();
   PolicyRule pr(ASK_BROKER);
   EXPECT_TRUE(pr.AddStringMatch(IF, 0, L"z:\\Directory\\domo.txt",
               CASE_INSENSITIVE));
 
   PolicyGlobal* policy = MakePolicyMemory();
   const uint32 kFakeService = 2;
 
   LowLevelPolicy policyGen(policy);
   EXPECT_TRUE(policyGen.AddRule(kFakeService, &pr));
   EXPECT_TRUE(policyGen.Done());
@@ skipping 12 matching lines @@
   EXPECT_EQ(ASK_BROKER, pol_ev.GetAction());
 
   filename = L"Z:\\Directory\\domo.txt.tmp";
   result = pol_ev.Evaluate(kShortEval, eval_params, _countof(eval_params));
   EXPECT_EQ(NO_POLICY_MATCH, result);
 
   delete [] reinterpret_cast<char*>(policy);
 }
 
 TEST(PolicyEngineTest, SimpleIfNotStrMatch) {
+  SetupNtdllImports();
   PolicyRule pr(ASK_BROKER);
   EXPECT_TRUE(pr.AddStringMatch(IF_NOT, 0, L"c:\\Microsoft\\",
                                 CASE_SENSITIVE));
 
   PolicyGlobal* policy = MakePolicyMemory();
   const uint32 kFakeService = 2;
   LowLevelPolicy policyGen(policy);
 
   EXPECT_TRUE(policyGen.AddRule(kFakeService, &pr));
   EXPECT_TRUE(policyGen.Done());
@@ skipping 17 matching lines @@
 
   filename = L"c:\\Microsoft\\domo.txt";
   result = pol_ev.Evaluate(kShortEval, eval_params, _countof(eval_params));
   EXPECT_EQ(POLICY_MATCH, result);
   EXPECT_EQ(ASK_BROKER, pol_ev.GetAction());
 
   delete [] reinterpret_cast<char*>(policy);
 }
 
 TEST(PolicyEngineTest, SimpleIfNotStrMatchWild1) {
+  SetupNtdllImports();
   PolicyRule pr(ASK_BROKER);
   EXPECT_TRUE(pr.AddStringMatch(IF_NOT, 0, L"c:\\Microsoft\\*",
                                 CASE_SENSITIVE));
 
   PolicyGlobal* policy = MakePolicyMemory();
   const uint32 kFakeService = 3;
   LowLevelPolicy policyGen(policy);
 
   EXPECT_TRUE(policyGen.AddRule(kFakeService, &pr));
   EXPECT_TRUE(policyGen.Done());
@@ skipping 12 matching lines @@
 
   filename = L"c:\\MicroNerd\\domo.txt";
   result = pol_ev.Evaluate(kShortEval, eval_params, _countof(eval_params));
   EXPECT_EQ(POLICY_MATCH, result);
   EXPECT_EQ(ASK_BROKER, pol_ev.GetAction());
 
   delete [] reinterpret_cast<char*>(policy);
 }
 
 TEST(PolicyEngineTest, SimpleIfNotStrMatchWild2) {
+  SetupNtdllImports();
   PolicyRule pr(ASK_BROKER);
   EXPECT_TRUE(pr.AddStringMatch(IF_NOT, 0, L"c:\\Microsoft\\*.txt",
                                 CASE_SENSITIVE));
 
   PolicyGlobal* policy = MakePolicyMemory();
   const uint32 kFakeService = 3;
   LowLevelPolicy policyGen(policy);
 
   EXPECT_TRUE(policyGen.AddRule(kFakeService, &pr));
   EXPECT_TRUE(policyGen.Done());
@@ skipping 17 matching lines @@
 
   filename = L"c:\\Microsoft\\domo.bmp";
   result = pol_ev.Evaluate(kShortEval, eval_params, _countof(eval_params));
   EXPECT_EQ(POLICY_MATCH, result);
   EXPECT_EQ(ASK_BROKER, pol_ev.GetAction());
 
   delete [] reinterpret_cast<char*>(policy);
 }
 
 TEST(PolicyEngineTest, IfNotStrMatchTwoRulesWild1) {
+  SetupNtdllImports();
   PolicyRule pr(ASK_BROKER);
   EXPECT_TRUE(pr.AddStringMatch(IF_NOT, 0, L"c:\\Microsoft\\*",
                                 CASE_SENSITIVE));
   EXPECT_TRUE(pr.AddNumberMatch(IF, 1, 24, EQUAL));
 
   PolicyGlobal* policy = MakePolicyMemory();
   const uint32 kFakeService = 3;
   LowLevelPolicy policyGen(policy);
 
   EXPECT_TRUE(policyGen.AddRule(kFakeService, &pr));
@@ skipping 27 matching lines @@
 
   filename = L"c:\\Micronesia\\domo.txt";
   access = 42;
   result = pol_ev.Evaluate(kShortEval, eval_params, _countof(eval_params));
   EXPECT_EQ(NO_POLICY_MATCH, result);
 
   delete [] reinterpret_cast<char*>(policy);
 }
 
 TEST(PolicyEngineTest, IfNotStrMatchTwoRulesWild2) {
+  SetupNtdllImports();
   PolicyRule pr(ASK_BROKER);
   EXPECT_TRUE(pr.AddNumberMatch(IF, 1, 24, EQUAL));
   EXPECT_TRUE(pr.AddStringMatch(IF_NOT, 0, L"c:\\GoogleV?\\*.txt",
                                 CASE_SENSITIVE));
   EXPECT_TRUE(pr.AddNumberMatch(IF, 2, 66, EQUAL));
 
   PolicyGlobal* policy = MakePolicyMemory();
   const uint32 kFakeService = 3;
   LowLevelPolicy policyGen(policy);
 
@@ skipping 52 matching lines @@
   sharing = 0;
   result = pol_ev.Evaluate(kShortEval, eval_params, _countof(eval_params));
   EXPECT_EQ(NO_POLICY_MATCH, result);
 
   delete [] reinterpret_cast<char*>(policy);
 }
 
 // Testing one single rule in one single service. The service is made to
 // resemble NtCreateFile.
 TEST(PolicyEngineTest, OneRuleTest) {
+  SetupNtdllImports();
   PolicyRule pr(ASK_BROKER);
   EXPECT_TRUE(pr.AddStringMatch(IF, 0, L"c:\\*Microsoft*\\*.txt",
                                 CASE_SENSITIVE));
   EXPECT_TRUE(pr.AddNumberMatch(IF_NOT, 1, CREATE_ALWAYS, EQUAL));
   EXPECT_TRUE(pr.AddNumberMatch(IF, 2, FILE_ATTRIBUTE_NORMAL, EQUAL));
 
   PolicyGlobal* policy = MakePolicyMemory();
 
   const uint32 kNtFakeCreateFile = 7;
 
@@ skipping 50 matching lines @@
 
   filename = L"c:\\Microsoft\\1.ttt";
   result = pol_ev.Evaluate(kShortEval, eval_params, _countof(eval_params));
   EXPECT_EQ(NO_POLICY_MATCH, result);
 
   delete [] reinterpret_cast<char*>(policy);
 }
 
 // Testing 3 rules in 3 services. Two of the services resemble File services.
 TEST(PolicyEngineTest, ThreeRulesTest) {
+  SetupNtdllImports();
   PolicyRule pr_pipe(FAKE_SUCCESS);
   EXPECT_TRUE(pr_pipe.AddStringMatch(IF, 0, L"\\\\/?/?\\Pipe\\Chrome.*",
                                      CASE_INSENSITIVE));
   EXPECT_TRUE(pr_pipe.AddNumberMatch(IF, 1, OPEN_EXISTING, EQUAL));
   EXPECT_TRUE(pr_pipe.AddNumberMatch(IF, 2, FILE_ATTRIBUTE_NORMAL, EQUAL));
 
   size_t opc1 = pr_pipe.GetOpcodeCount();
   EXPECT_EQ(3, opc1);
 
   PolicyRule pr_dump(ASK_BROKER);
@@ skipping 168 matching lines @@
   result = eval_None.Evaluate(kShortEval, params, _countof(params));
   EXPECT_EQ(NO_POLICY_MATCH, result);
   result = eval_OpenFile.Evaluate(kShortEval, params, _countof(params));
   EXPECT_EQ(POLICY_MATCH, result);
   EXPECT_EQ(FAKE_SUCCESS, eval_OpenFile.GetAction());
 
   delete [] reinterpret_cast<char*>(policy);
 }
 
 }  // namespace sandbox