Issue 113539: linux: unify all the dialog layout code for visual consistency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113539: linux: unify all the dialog layout code for visual consistency. (Closed)

Created:
11 years, 7 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: unify all the dialog layout code for visual consistency. We follow the GNOME HIG where possible, which mostly means the pixel spacing of the borders and buttons in dialogs. BUG=12056

Patch Set 1 #

Patch Set 2 : last second #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -75 lines)			Patch
M	chrome/browser/browser_main.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/about_chrome_dialog.cc	View		3 chunks	+14 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_editor_gtk.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_editor_gtk.cc	View	1	5 chunks	+43 lines, -42 lines	0 comments	Download
M	chrome/browser/gtk/hung_renderer_dialog_gtk.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/import_dialog_gtk.cc	View		2 chunks	+19 lines, -24 lines	0 comments	Download
M	chrome/browser/gtk/options/options_window_gtk.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/gtk_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/gtk_util.cc	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks for doing this.

Expand Messages | Collapse Messages