Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: chrome/browser/gtk/options/options_window_gtk.cc

Issue 113539: linux: unify all the dialog layout code for visual consistency. (Closed)
Patch Set: last second Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/gtk/import_dialog_gtk.cc ('k') | chrome/common/gtk_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <gtk/gtk.h> 5 #include <gtk/gtk.h>
6 6
7 #include "chrome/browser/options_window.h" 7 #include "chrome/browser/options_window.h"
8 8
9 #include "app/l10n_util.h" 9 #include "app/l10n_util.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 dialog_ = gtk_dialog_new_with_buttons( 73 dialog_ = gtk_dialog_new_with_buttons(
74 l10n_util::GetStringFUTF8(IDS_OPTIONS_DIALOG_TITLE, 74 l10n_util::GetStringFUTF8(IDS_OPTIONS_DIALOG_TITLE,
75 WideToUTF16(l10n_util::GetString(IDS_PRODUCT_NAME))).c_str(), 75 WideToUTF16(l10n_util::GetString(IDS_PRODUCT_NAME))).c_str(),
76 // Prefs window is shared between all browser windows. 76 // Prefs window is shared between all browser windows.
77 NULL, 77 NULL,
78 // Non-modal. 78 // Non-modal.
79 GTK_DIALOG_NO_SEPARATOR, 79 GTK_DIALOG_NO_SEPARATOR,
80 GTK_STOCK_CLOSE, 80 GTK_STOCK_CLOSE,
81 GTK_RESPONSE_CLOSE, 81 GTK_RESPONSE_CLOSE,
82 NULL); 82 NULL);
83 gtk_box_set_spacing(GTK_BOX(GTK_DIALOG(dialog_)->vbox), 18);
83 84
84 notebook_ = gtk_notebook_new(); 85 notebook_ = gtk_notebook_new();
85 86
86 gtk_notebook_append_page( 87 gtk_notebook_append_page(
87 GTK_NOTEBOOK(notebook_), 88 GTK_NOTEBOOK(notebook_),
88 gtk_label_new("TODO general"), 89 gtk_label_new("TODO general"),
89 gtk_label_new( 90 gtk_label_new(
90 l10n_util::GetStringUTF8(IDS_OPTIONS_GENERAL_TAB_LABEL).c_str())); 91 l10n_util::GetStringUTF8(IDS_OPTIONS_GENERAL_TAB_LABEL).c_str()));
91 92
92 gtk_notebook_append_page( 93 gtk_notebook_append_page(
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 OptionsGroup highlight_group, 184 OptionsGroup highlight_group,
184 Profile* profile) { 185 Profile* profile) {
185 DCHECK(profile); 186 DCHECK(profile);
186 // If there's already an existing options window, activate it and switch to 187 // If there's already an existing options window, activate it and switch to
187 // the specified page. 188 // the specified page.
188 if (!instance_) { 189 if (!instance_) {
189 instance_ = new OptionsWindowGtk(profile); 190 instance_ = new OptionsWindowGtk(profile);
190 } 191 }
191 instance_->ShowOptionsPage(page, highlight_group); 192 instance_->ShowOptionsPage(page, highlight_group);
192 } 193 }
OLDNEW
« no previous file with comments | « chrome/browser/gtk/import_dialog_gtk.cc ('k') | chrome/common/gtk_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698