Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issue 113517: Revert "Revert "Revert "Add connected socket function to ClientSocketPool and ClientSocketHandle.""" (Closed)

Created:
11 years, 7 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Revert "Revert "Revert "Add connected socket function to ClientSocketPool and ClientSocketHandle.""" Revert "Fix a memory leak in client_socket_pool_unittest.cc." Guess I still fail. kasperl pointed out that this managed to break layout tests and some reliability tests too. TBR=wtc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -781 lines) Patch
M base/stl_util-inl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M net/base/client_socket_handle.h View 2 chunks +18 lines, -36 lines 0 comments Download
M net/base/client_socket_handle.cc View 1 chunk +9 lines, -42 lines 0 comments Download
M net/base/client_socket_pool.h View 7 chunks +32 lines, -94 lines 0 comments Download
M net/base/client_socket_pool.cc View 9 chunks +33 lines, -240 lines 0 comments Download
M net/base/client_socket_pool_unittest.cc View 8 chunks +88 lines, -186 lines 0 comments Download
M net/base/test_completion_callback.h View 2 chunks +1 line, -1 line 0 comments Download
M net/http/http_network_layer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +2 lines, -5 lines 0 comments Download
M net/http/http_network_transaction.h View 4 chunks +27 lines, -24 lines 0 comments Download
M net/http/http_network_transaction.cc View 12 chunks +103 lines, -30 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 37 chunks +63 lines, -114 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
willchan no longer on Chromium
11 years, 7 months ago (2009-05-18 06:44:30 UTC) #1
wtc
11 years, 7 months ago (2009-05-18 18:10:50 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698