chrome/chrome_browser.gypi - Issue 11348052: [sync] Componentize sync: Part 1: Clean up sync.gyp and update chrome / test dependencies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 11348052: [sync] Componentize sync: Part 1: Clean up sync.gyp and update chrome / test dependencies (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove comment Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 251f94b1eabc8b62e61e47a734e5d2d96faf3703..98d7a0f3ac6fbaf4916831b303f86887e8e7f0e5 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -34,11 +34,8 @@

'../google_apis/google_apis.gyp:google_apis',

'../media/media.gyp:media',

'../skia/skia.gyp:skia',

- '../sync/protocol/sync_proto.gyp:sync_proto',

akalin 2012/11/08 01:01:51 here, too. why are you removing these dependencie

Raghu Simha 2012/11/08 22:34:39 Same reasoning as in my comment on sync.gyp. I've

- # TODO(akalin): Depend only on syncapi_service from sync.

- '../sync/sync.gyp:syncapi_core',

- '../sync/sync.gyp:syncapi_service',

- '../sync/sync.gyp:sync_notifier',

+ '../sync/sync.gyp:sync_api',

+ '../sync/sync.gyp:sync_internal_api',

'../third_party/bzip2/bzip2.gyp:bzip2',

'../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation',

'../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation_proto_cpp',

@@ -59,9 +56,6 @@

# Needed by pepper_flash_component_installer.cc.

'<(SHARED_INTERMEDIATE_DIR)',

- 'export_dependent_settings': [

- '../sync/sync.gyp:sync_notifier',

- ],

'sources': [

# All .cc, .h, .m, and .mm files under browser except for:

# * tests and mocks.

« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | sync/sync.gyp » ('J')