[sync] Componentize sync: Part 1: Clean up sync.gyp and update chrome / test dependencies

chrome/chrome_browser.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'browser',
       'type': 'static_library',
@@ skipping 16 matching lines @@
         'safe_browsing_report_proto',
         'variations_seed_proto',
         '../build/temp_gyp/googleurl.gyp:googleurl',
         '../cc/cc.gyp:cc',
         '../content/content.gyp:content_browser',
         '../content/content.gyp:content_common',
         '../crypto/crypto.gyp:crypto',
         '../google_apis/google_apis.gyp:google_apis',
         '../media/media.gyp:media',
         '../skia/skia.gyp:skia',
-        '../sync/protocol/sync_proto.gyp:sync_proto',

[akalin, 2012/11/08 01:01:51]

here, too.  why are you removing these dependencies?  pretty sure they're all
still valid.  you should either replace them with a dependency on 'sync', or
just rename them.

[Raghu Simha, 2012/11/08 22:34:39]

Same reasoning as in my comment on sync.gyp. I've re-added the targets.

-        # TODO(akalin): Depend only on syncapi_service from sync.
-        '../sync/sync.gyp:syncapi_core',
-        '../sync/sync.gyp:syncapi_service',
-        '../sync/sync.gyp:sync_notifier',
+        '../sync/sync.gyp:sync_api',
+        '../sync/sync.gyp:sync_internal_api',
         '../third_party/bzip2/bzip2.gyp:bzip2',
         '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation',
         '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation_proto_cpp',
         '../third_party/icu/icu.gyp:icui18n',
         '../third_party/icu/icu.gyp:icuuc',
         '../third_party/libusb/libusb.gyp:libusb',
         '../third_party/libxml/libxml.gyp:libxml',
         '../third_party/zlib/zlib.gyp:minizip',
         '../third_party/zlib/zlib.gyp:zlib',
         '../ui/base/strings/ui_strings.gyp:ui_strings',
         '../ui/ui.gyp:ui',
         '../ui/ui.gyp:ui_resources',
         '../webkit/support/webkit_support.gyp:user_agent',
       ],
       'include_dirs': [
         '..',
         '<(INTERMEDIATE_DIR)',
         # Needed by pepper_flash_component_installer.cc.
         '<(SHARED_INTERMEDIATE_DIR)',
       ],
-      'export_dependent_settings': [
-        '../sync/sync.gyp:sync_notifier',
-      ],
       'sources': [
         # All .cc, .h, .m, and .mm files under browser except for:
         # * tests and mocks.
         # * code below browser/chromeos
         # * code below browser/extensions
         'browser/about_flags.cc',
         'browser/about_flags.h',
         'browser/about_flags_android.cc',
         'browser/accessibility/accessibility_extension_api_constants.cc',
         'browser/accessibility/accessibility_extension_api_constants.h',
@@ skipping 2936 matching lines @@
             'proto_in_dir': '../third_party/cros_system_api/dbus',
             'proto_out_dir': 'chrome/browser/media_transfer_protocol',
           },
           'includes': ['../build/protoc.gypi'],
         },
       ],
      },
     ],
   ],
 }