Shorten the new proxy switch names.

Shorten the new proxy switch names.
BUG=266
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16188

[wtc, 2009-05-15 17:13:08]

LGTM.  Thanks a lot!  I have some suggested changes
below.  You can check in without another review by me.

http://codereview.chromium.org/113465/diff/1/2
File chrome/browser/net/chrome_url_request_context.cc (right):

http://codereview.chromium.org/113465/diff/1/2#newcode51
Line 51: // the --no-proxy command line argument is present.
Let's not shorten --no-proxy-server because it is a common
convention that the opposite of the --xxx option is --no-xxx.
For example, the negation of GCC's -fxxx options is -fno-xxx:

http://gcc.gnu.org/onlinedocs/gcc-4.3.3/gcc/Option-Summary.html#Option-Summary

http://codereview.chromium.org/113465/diff/1/3
File chrome/common/chrome_switches.cc (left):

http://codereview.chromium.org/113465/diff/1/3#oldcode238
Line 238: const wchar_t kNoProxyServer[]                 = L"no-proxy-server";
Let's not shorten no-proxy-server.

http://codereview.chromium.org/113465/diff/1/3
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/113465/diff/1/3#newcode241
Line 241: // connections. Ignored if --proxy-auto-detect or --no-proxy are
Change --no-proxy back to --no-proxy-server

http://codereview.chromium.org/113465/diff/1/3#newcode244
Line 244: const wchar_t kProxyServerBypassUrls[]         = L"proxy-bypass-urls";
Nit: you may want to shorten the constants' names, too:
kProxyBypassUrls, kProxyAutoDetect, kProxyPacUrl

[robertshield, 2009-05-15 17:32:53]

http://codereview.chromium.org/113465/diff/1/2
File chrome/browser/net/chrome_url_request_context.cc (right):

http://codereview.chromium.org/113465/diff/1/2#newcode51
Line 51: // the --no-proxy command line argument is present.
On 2009/05/15 17:13:08, wtc wrote:
> Let's not shorten --no-proxy-server because it is a common
> convention that the opposite of the --xxx option is --no-xxx.
> For example, the negation of GCC's -fxxx options is -fno-xxx:
> 
> http://gcc.gnu.org/onlinedocs/gcc-4.3.3/gcc/Option-Summary.html#Option-Summary

Sounds good, I guess I got a bit overzealous in my shortening ;-)

http://codereview.chromium.org/113465/diff/1/3
File chrome/common/chrome_switches.cc (left):

http://codereview.chromium.org/113465/diff/1/3#oldcode238
Line 238: const wchar_t kNoProxyServer[]                 = L"no-proxy-server";
On 2009/05/15 17:13:08, wtc wrote:
> Let's not shorten no-proxy-server.

Done.

http://codereview.chromium.org/113465/diff/1/3
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/113465/diff/1/3#newcode241
Line 241: // connections. Ignored if --proxy-auto-detect or --no-proxy are
On 2009/05/15 17:13:08, wtc wrote:
> Change --no-proxy back to --no-proxy-server

Done.

http://codereview.chromium.org/113465/diff/1/3#newcode244
Line 244: const wchar_t kProxyServerBypassUrls[]         = L"proxy-bypass-urls";
On 2009/05/15 17:13:08, wtc wrote:
> Nit: you may want to shorten the constants' names, too:
> kProxyBypassUrls, kProxyAutoDetect, kProxyPacUrl

Done.

[wtc, 2009-05-15 17:45:31]

LGTM.  Don't forget to add BUG=266 to this issue.

http://codereview.chromium.org/113465/diff/1004/1007
File chrome/browser/net/chrome_url_request_context_unittest.cc (right):

http://codereview.chromium.org/113465/diff/1004/1007#newcode36
Line 36: L".google.com, foo.com:99, 1.2.3.4:22, 127.0.0.1/8");
Nit: Hmm... these are not really URLs.  Perhaps we should
rename the option --proxy-bypass-hosts or --proxy-bypass-list?

Let's leave this as is for now and ask eroman.

[eroman, 2009-05-15 18:53:03]

http://codereview.chromium.org/113465/diff/1004/1007
File chrome/browser/net/chrome_url_request_context_unittest.cc (right):

http://codereview.chromium.org/113465/diff/1004/1007#newcode36
Line 36: L".google.com, foo.com:99, 1.2.3.4:22, 127.0.0.1/8");
On 2009/05/15 17:45:32, wtc wrote:
> Nit: Hmm... these are not really URLs.  Perhaps we should
> rename the option --proxy-bypass-hosts or --proxy-bypass-list?
> 
> Let's leave this as is for now and ask eroman.

I agree --proxy-bypass-list would be a better switch name.