Shorten the new proxy switch names.

chrome/browser/net/chrome_url_request_context_unittest.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "chrome/common/chrome_switches.h"
 #include "net/proxy/proxy_config.h"
 #include "net/proxy/proxy_config_service_common_unittest.h"
 
@@ skipping 14 matching lines @@
   CommandLine single_proxy(L"foo.exe");
   single_proxy.AppendSwitchWithValue(switches::kProxyServer,
       L"http://proxy:8888");
   CommandLine per_scheme_proxy(L"foo.exe");
   per_scheme_proxy.AppendSwitchWithValue(switches::kProxyServer,
       L"http=httpproxy:8888;ftp=ftpproxy:8889");
   CommandLine per_scheme_proxy_bypass(L"foo.exe");
   per_scheme_proxy_bypass.AppendSwitchWithValue(switches::kProxyServer,
       L"http=httpproxy:8888;ftp=ftpproxy:8889");
   per_scheme_proxy_bypass.AppendSwitchWithValue(
-      switches::kProxyServerBypassUrls,
+      switches::kProxyBypassUrls,
       L".google.com, foo.com:99, 1.2.3.4:22, 127.0.0.1/8");

[wtc, 2009/05/15 17:45:32]

Nit: Hmm... these are not really URLs.  Perhaps we should
rename the option --proxy-bypass-hosts or --proxy-bypass-list?

Let's leave this as is for now and ask eroman.

[eroman, 2009/05/15 18:53:04]

I agree --proxy-bypass-list would be a better switch name.

   CommandLine with_pac_url(L"foo.exe");
-  with_pac_url.AppendSwitchWithValue(switches::kProxyServerPacUrl,
+  with_pac_url.AppendSwitchWithValue(switches::kProxyPacUrl,
       L"http://wpad/wpad.dat");
   with_pac_url.AppendSwitchWithValue(
-      switches::kProxyServerBypassUrls,
+      switches::kProxyBypassUrls,
       L".google.com, foo.com:99, 1.2.3.4:22, 127.0.0.1/8");
   CommandLine with_auto_detect(L"foo.exe");
-  with_auto_detect.AppendSwitch(switches::kProxyServerAutoDetect);
+  with_auto_detect.AppendSwitch(switches::kProxyAutoDetect);
 
   // Inspired from proxy_config_service_win_unittest.cc.
   const struct {
     // Short description to identify the test
     std::string description;
 
     // The command line to build a ProxyConfig from.
     const CommandLine& command_line;
 
     // Expected outputs (fields of the ProxyConfig).
@@ skipping 117 matching lines @@
       EXPECT_TRUE(config != NULL);
       EXPECT_EQ(tests[i].auto_detect, config->auto_detect);
       EXPECT_EQ(tests[i].pac_url, config->pac_url);
       EXPECT_EQ(tests[i].proxy_bypass_list,
                 net::FlattenProxyBypass(config->proxy_bypass));
       EXPECT_EQ(tests[i].bypass_local_names, config->proxy_bypass_local_names);
       EXPECT_EQ(tests[i].proxy_rules, config->proxy_rules);
     }
   }
 }