[Sync] Fix up users who were affected by bug 154940

[Sync] Fix up users who were affected by bug 154940

These users did not have their Keep Everything Synced preference set
properly, or the preferences for the preferred datatypes. We detect this
and manually fix up the preference before reconfiguring sync.

BUG=158391
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164975

[Nicolas Zea, 2012-10-29 22:07:57]

PTAL. Tested manually by repro'ing bug 154940 and it did the trick.

[tim (not reviewing), 2012-10-29 23:25:23]

https://codereview.chromium.org/11342022/diff/4001/chrome/browser/sync/profil...
File chrome/browser/sync/profile_sync_service_startup_unittest.cc (right):

https://codereview.chromium.org/11342022/diff/4001/chrome/browser/sync/profil...
chrome/browser/sync/profile_sync_service_startup_unittest.cc:281: // Clear the
datatype preference fields (simulating bug 154940).
Can you also write a test to cover the case where only bookmarks was enabled
(and kSyncKeepEverythingSynced was explicitly false)?

https://codereview.chromium.org/11342022/diff/4001/chrome/browser/sync/profil...
chrome/browser/sync/profile_sync_service_startup_unittest.cc:296:
service_->GetRegisteredDataTypes()));
nit - indent

[Nicolas Zea, 2012-10-30 00:05:58]

PTAL.

https://codereview.chromium.org/11342022/diff/4001/chrome/browser/sync/profil...
File chrome/browser/sync/profile_sync_service_startup_unittest.cc (right):

https://codereview.chromium.org/11342022/diff/4001/chrome/browser/sync/profil...
chrome/browser/sync/profile_sync_service_startup_unittest.cc:281: // Clear the
datatype preference fields (simulating bug 154940).
On 2012/10/29 23:25:24, timsteele wrote:
> Can you also write a test to cover the case where only bookmarks was enabled
> (and kSyncKeepEverythingSynced was explicitly false)?

Done (and check that it's true in this test). I realized also that these tests
don't actually have any registered types, so removed that check.
KeepEverythingSynced is all we can really verify here.

https://codereview.chromium.org/11342022/diff/4001/chrome/browser/sync/profil...
chrome/browser/sync/profile_sync_service_startup_unittest.cc:296:
service_->GetRegisteredDataTypes()));
On 2012/10/29 23:25:24, timsteele wrote:
> nit - indent

Done.

[tim (not reviewing), 2012-10-30 00:13:22]

LGTM

[commit-bot: I haz the power, 2012-10-30 00:21:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/11342022/10002

[commit-bot: I haz the power, 2012-10-30 04:14:53]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-10-30 17:16:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/11342022/10002

[commit-bot: I haz the power, 2012-10-30 19:39:42]

Change committed as 164975

[kinuko, 2012-11-01 11:17:53]

After landing this ProfileSyncServiceStartupTest.StartRecoverDatatypePrefs is
failing on multiple bots:

http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/bui...