Improve algorithm for detaching and attaching a virtual frame to the code...

Improve algorithm for detaching and attaching a virtual frame to the code
generator.  Inline copying of a register file.

Committed: http://code.google.com/p/v8/source/detail?r=1954

[Kevin Millikin (Chromium), 2009-05-14 15:41:49]

LGTM.

http://codereview.chromium.org/113402/diff/1/6
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/113402/diff/1/6#newcode134
Line 134: Register temp = { i };
It might be better to overload RegisterAllocator::Unuse to have an int (and call
it in the Register version).

[William Hesse, 2009-05-15 15:44:40]

http://codereview.chromium.org/113402/diff/1/6
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/113402/diff/1/6#newcode134
Line 134: Register temp = { i };
On 2009/05/14 15:41:49, Kevin Millikin wrote:
> It might be better to overload RegisterAllocator::Unuse to have an int (and
call
> it in the Register version).

This completely disappears in the generated assembly code, so is it worthwhile
adding the extra (inlined) functions just to make this look nicer?