Bypass an expensive computation of a basic block's entry frame for a...

src/ia32/virtual-frame-ia32.h

Index: src/ia32/virtual-frame-ia32.h
===================================================================
--- src/ia32/virtual-frame-ia32.h	(revision 1953)
+++ src/ia32/virtual-frame-ia32.h	(working copy)
@@ -116,6 +116,13 @@
   // (ie, they all have frame-external references).
   Register SpillAnyRegister();
 

[William Hesse, 2009/05/15 07:45:51]

How about:
// Remove copies and constants from the top mergeable_elements of the frame,
// so that a frame of the same height that differs only on
these elements can be merged to it.
// Use JumpTarget::kAllElements if the entire frame should be made mergeable.

[Kevin Millikin (Chromium), 2009/05/15 08:03:35]

Seems misleading.  The arbitrary frame could differ anywhere (could have memory
where this one has register, or they could have different registers).  I'd
rather stick to the accurate wording even if it's more verbose.

I'll change the "not allowed" so it's clear it's a postcondition and not a
precondition.

+  // Make this frame so that an arbitrary frame of the same height can
+  // be merged to it.  Copies and constants are removed from the
+  // topmost mergable_elements elements of the frame.  A
+  // mergable_elements of JumpTarget::kAllElements indicates constants
+  // and copies are not allowed anywhere in the frame.
+  void MakeMergable(int mergable_elements);
+
   // Prepare this virtual frame for merging to an expected frame by
   // performing some state changes that do not require generating
   // code.  It is guaranteed that no code will be generated.